-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-0.13.x] Update MSRV to 1.63.0 #487
[release-0.13.x] Update MSRV to 1.63.0 #487
Conversation
For the next 0.13.x release, we need a newer MSRV, because the log dependency does not build with 1.59.0 anymore. So we update the MSRV here. Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
3e0361c
to
d97b904
Compare
For the next 0.13.x release, we need a newer MSRV, because the pest_meta (transitive) dependency does not build with 1.60.0 anymore. So we update the MSRV here. Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
For the next 0.13.x release, we need a newer MSRV, because the rustix (transitive) dependency does not build with 1.61.0 anymore. So we update the MSRV here. Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
I don't like where this is going... |
Signed-off-by: Matthias Beyer <mail@beyermatthias.de> (cherry picked from commit 8b2bdfe) Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
UUuuh all green now. @ijackson you're welcome to experiment on another solution. If that does not work out, we can merge this PR instead. |
There's a cargo command (third-party IIRC) that can be used to identify the MSRV for a project based on its dependencies I think? You may want to also manage it in the |
Instead of this MR, how about the approach I took in #492 ? |
FWIW, The MSRV of many crates during my investigation were averaging around
I think Nothing else in TL;DR
|
|
Foe the next 0.13.x release, we need a newer MSRV, because the
log
dependency does not build with 1.59.0 anymore.So we update the MSRV here.